Skip to content

chore(cli): temporarily fix pnpm install warnning messages#177

Merged
fengmk2 merged 1 commit into
mainfrom
09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps
Sep 22, 2025
Merged

chore(cli): temporarily fix pnpm install warnning messages#177
fengmk2 merged 1 commit into
mainfrom
09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 22, 2025

Copy link
Copy Markdown
Member

TL;DR

Added catalog versioning for dev dependencies and updated peer dependency rules for vite in monorepo templates.

What changed?

  • Modified fixPackageJsonForVitePlus function to use catalog versioning for common dev dependencies when not using Vite Plus
  • Added catalog versioning for: @types/node, bumpp, happy-dom, vitest, typescript, tsdown, and vite
  • Updated pnpm-workspace.yaml to include peer dependency rules that allow any version of vite

How to test?

  1. Create a new project without Vite Plus
  2. Verify that the specified dev dependencies use catalog versioning in package.json
  3. Create a new monorepo project and check that the pnpm-workspace.yaml contains the new peer dependency rules

Why make this change?

This change improves dependency management in projects by leveraging catalog versioning for common dev dependencies, ensuring consistent versions across projects. The peer dependency rule for vite helps prevent version conflicts when different packages in the monorepo have different vite version requirements.

@fengmk2
fengmk2 requested a review from wan9chi September 22, 2025 01:14
@fengmk2 fengmk2 self-assigned this Sep 22, 2025
@fengmk2
fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch from e569935 to b82700f Compare September 22, 2025 01:38
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch from 7fc6bde to e1f4e74 Compare September 22, 2025 01:38
@fengmk2
fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch 2 times, most recently from 24b2f36 to e042d94 Compare September 22, 2025 01:59
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch 2 times, most recently from aa027a5 to 4f878e6 Compare September 22, 2025 02:32
@fengmk2
fengmk2 marked this pull request as ready for review September 22, 2025 02:33
@fengmk2
fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch from e042d94 to 3e7a55b Compare September 22, 2025 02:54
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch 2 times, most recently from c9a37c4 to fc70993 Compare September 22, 2025 04:41
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch from fc70993 to 8bb4b9f Compare September 22, 2025 04:43
@fengmk2
fengmk2 changed the base branch from 09-21-fix_cli_add_missing_lib_command to graphite-base/177 September 22, 2025 07:21
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch from 8bb4b9f to e63a92d Compare September 22, 2025 07:22
@graphite-app
graphite-app Bot changed the base branch from graphite-base/177 to main September 22, 2025 07:22
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch from e63a92d to 9bbc43f Compare September 22, 2025 07:22
@fengmk2
fengmk2 merged commit 8eb6a0e into main Sep 22, 2025
9 checks passed

fengmk2 commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

Merge activity

@fengmk2
fengmk2 deleted the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch September 22, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants